go-docappender: use a fixed-size buffer #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic-apm-tech
added
the
safe-to-test
vikmik
force-pushed
the
vic-124-alternative
branch
3 times, most recently
from
d38b04b to
fb07dd0
Compare
vikmik
commented
Feb 23, 2024
Comment on lines
+237
to
+238
| n := copy(b.copyBuf, b.buf.Bytes()) | ||
| b.copyBuf = b.copyBuf[:n] |
There was a problem hiding this comment.
Prior to this PR there was no error handling of the gzip reader.
I fixed that below, but that required resizing down copyBuf here when necessary - otherwise there might be unrelated data from previous flushes, causing failed gzip reads.
vikmik
force-pushed
the
vic-124-alternative
branch
from
fb07dd0 to
401a4b3
Compare
|
Closing in favor of #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of PR #124 that doesn't require expanding the buffer, and requires fewer variables to track positions (hopefully improving maintainability)